[Spice-devel] [PATCH spice-gtk 0/2] a couple async usb fixes

Jonathon Jongsma jjongsma at redhat.com
Thu Mar 24 20:29:22 UTC 2016


I discovered that the UsbDeviceManager doesn't handle device connection errors
properly after the latest GTask and async usb changes. I reproduced this
because my usb acl helper executable wasn't properly owned by root with u+s, so
the set_facl() function failed. In this situation, the usb device widget was
left in an unusable state with a blue info bar saying 'device is being
redirected...' (or something similar).

Clearly this was a acl-helper issue was problem with my environment, but
spice-gtk should still deal with that situation properly. These two patches
should fix the issue.

Jonathon Jongsma (2):
  SpiceUsbDeviceManager: propagate errors from sub-tasks
  usb device widget: don't try to disconnect on failed connect

 src/usb-device-manager.c | 20 ++++++++++++++++++--
 src/usb-device-widget.c  |  6 ++++++
 2 files changed, 24 insertions(+), 2 deletions(-)

-- 
2.4.3



More information about the Spice-devel mailing list