[Spice-devel] [PATCH 03/10] spicevmc: Introduce RedCharDeviceSpiceVmc GObject

[Frediano Ziglio]

> On Thu, Mar 31, 2016 at 04:23:47AM -0400, Frediano Ziglio wrote:
> > > 
> > > On Wed, 2016-03-30 at 18:21 +0100, Frediano Ziglio wrote:
> > > > From: Christophe Fergeau <cfergeau at redhat.com>
> > > > 
> > > > ---
> > > >  server/spicevmc.c | 80
> > > >  +++++++++++++++++++++++++++++++++++++++++++++---------
> > > > -
> > > >  1 file changed, 66 insertions(+), 14 deletions(-)
> > > > 
> > > > diff --git a/server/spicevmc.c b/server/spicevmc.c
> > > > index 367132c..666941f 100644
> > > > --- a/server/spicevmc.c
> > > > +++ b/server/spicevmc.c
> > > > @@ -61,6 +61,33 @@ typedef struct SpiceVmcState {
> > > >      uint8_t port_opened;
> > > >  } SpiceVmcState;
> > > >  
> > > > +#define RED_TYPE_CHAR_DEVICE_SPICEVMC
> > > > red_char_device_spicevmc_get_type()
> > > > +
> > > > +#define RED_CHAR_DEVICE_SPICEVMC(obj)
> > > > (G_TYPE_CHECK_INSTANCE_CAST((obj),
> > > > RED_TYPE_CHAR_DEVICE_SPICEVMC, RedCharDeviceSpiceVmc))
> > > > +#define RED_CHAR_DEVICE_SPICEVMC_CLASS(klass)
> > > > (G_TYPE_CHECK_CLASS_CAST((klass), RED_TYPE_CHAR_DEVICE_SPICEVMC,
> > > > RedCharDeviceSpiceVmcClass))
> > > > +#define RED_IS_CHAR_DEVICE_SPICEVMC(obj)
> > > > (G_TYPE_CHECK_INSTANCE_TYPE((obj),
> > > > RED_TYPE_CHAR_DEVICE_SPICEVMC))
> > > > +#define RED_IS_CHAR_DEVICE_SPICEVMC_CLASS(klass)
> > > > (G_TYPE_CHECK_CLASS_TYPE((klass), RED_TYPE_CHAR_DEVICE_SPICEVMC))
> > > > +#define RED_CHAR_DEVICE_SPICEVMC_GET_CLASS(obj)
> > > > (G_TYPE_INSTANCE_GET_CLASS((obj), RED_TYPE_CHAR_DEVICE_SPICEVMC,
> > > > RedCharDeviceSpiceVmcClass))
> > > > +
> > > > +typedef struct RedCharDeviceSpiceVmc RedCharDeviceSpiceVmc;
> > 
> > Why using Red and Spice on the same name? Should not be RedCharDeviceVmc
> > clear enough?
> 
> Dunno, just kept the spicevmc name which is used everywhere I think.
> It's even used in libvirt XML. Then added Red for namespacing reasons.
> SpiceVmc is just an opaque name to me.
> 
> Christophe
> 

libvirt IMHO is not enforcing this. I would be surprised if libvirt based
its naming on the internal naming conventions of spice-server, it's just
using public names so it has to be SpiceVmc.

Frediano