[Spice-devel] [PATCH 00/15] Simplify current_add_equal function loop

Frediano Ziglio fziglio at redhat.com
Mon May 16 16:40:25 UTC 2016


These patches should be probably squashed together.
I still don't get that much what the loop is supposed to
achieve but surely now is much neat.
Also I removed a code assumption (it all started from there).
Can somebody explain what the code is supposed to do?

Frediano Ziglio (15):
  dc: convert to infinite loop
  dc: split if
  dc: the worker_ring_item condition make this case terminate loop
  dc: worker_ring_item is never null here
  dc: dcc used is always a value from current worker_ring_item
  dc: move code inside if
  dc: dpi is always a value computed from dpi_ring_item
  dc: if dpi is not NULL even dpi_ring_item is not NULL
  dc: if worker_ring_item is NULL jumping outside loop will check
    variable and exit
  dc: use while again
  dc: convert break to continue
  dc: reuse code inside loop
  dc: join the two loop
  dc: inline dpi computation
  dc: use RING_FOREACH macro for loop

 server/display-channel.c | 21 ++++-----------------
 1 file changed, 4 insertions(+), 17 deletions(-)

-- 
2.7.4



More information about the Spice-devel mailing list