[Spice-devel] [PATCH] make spice-server-replay utility smaller

[Christophe Fergeau]

On Tue, May 17, 2016 at 12:28:30PM -0400, Frediano Ziglio wrote:
> > 
> > Acked-by: Christophe Fergeau <cfergeau at redhat.com>
> > 
> > though it took me a bit to understand what this was about, the commit
> > log could probably be a bit clearer.
> > 
> > Christophe
> > 
> 
> I was going to open the commit with a "spice-server-replay is fat!" but
> I changed my mind!
> 
> I could try...
> ----
> make spice-server-replay use dynamic spice-server library
> 
> spice-server-replay is built with the same settings as tests.
> Currently the tests links to a convenience spice-server library.
> A convenience library is a static library build with object file
> for a dynamic library.
> This make all tests contain all spice-server library code and not
> linking to the spice-server dynamic library (the .so).
> It's not a problem for most tests however this make impossible for
> spice-server-replay utility to be used with a dynamic spice-server
> library (you have to recompile it including the library).
> This is a pity as you could for instance compare your system
> library behavior with the library you are developing.
> Also if we decide to install in a future the utility for testing
> we wound have lot of code duplication.

'we would' in the last sentence?

Acked-by: Christophe Fergeau <cfergeau at redhat.com>
the short log is very descriptive now!

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160518/1bf9376c/attachment.sig>