[Spice-devel] [spice-gtk v1 2/2] tests: set binaries to have 'test' name prefix

[Christophe Fergeau]

Why not,

Acked-by: Christophe Fergeau <cfergeau at redhat.com>

On Fri, Sep 30, 2016 at 05:11:48PM +0200, victortoso at redhat.com wrote:
> From: Victor Toso <me at victortoso.com>
> 
> To follow test-spice-uri and test-file-transfer standard.
> ---
>  tests/Makefile.am      | 26 +++++++++++++-------------
>  tests/usb-acl-helper.c |  2 +-
>  2 files changed, 14 insertions(+), 14 deletions(-)
> 
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index 6d9cfeb..3a0188d 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -1,20 +1,20 @@
>  NULL =
>  
>  noinst_PROGRAMS =
> -TESTS = coroutine				\
> -	util					\
> -	session					\
> +TESTS = test-coroutine				\
> +	test-util				\
> +	test-session				\
>  	test-spice-uri				\
>  	test-file-transfer			\
>  	$(NULL)
>  
>  if WITH_PHODAV
> -TESTS += pipe
> +TESTS += test-pipe
>  endif
>  
>  if WITH_POLKIT
> -TESTS += usb-acl-helper
> -noinst_PROGRAMS += mock-acl-helper
> +TESTS += test-usb-acl-helper
> +noinst_PROGRAMS += test-mock-acl-helper
>  endif
>  
>  noinst_PROGRAMS += $(TESTS)
> @@ -34,14 +34,14 @@ LDADD =							\
>  	$(top_builddir)/src/libspice-client-glib-2.0.la	\
>  	$(NULL)
>  
> -util_SOURCES = util.c
> -coroutine_SOURCES = coroutine.c
> -session_SOURCES = session.c
> -pipe_SOURCES = pipe.c
> +test_util_SOURCES = util.c
> +test_coroutine_SOURCES = coroutine.c
> +test_session_SOURCES = session.c
> +test_pipe_SOURCES = pipe.c
>  test_spice_uri_SOURCES = uri.c
>  test_file_transfer_SOURCES = file-transfer.c
> -usb_acl_helper_SOURCES = usb-acl-helper.c
> -usb_acl_helper_CFLAGS = -DTESTDIR=\"$(abs_builddir)\"
> -mock_acl_helper_SOURCES = mock-acl-helper.c
> +test_usb_acl_helper_SOURCES = usb-acl-helper.c
> +test_usb_acl_helper_CFLAGS = -DTESTDIR=\"$(abs_builddir)\"
> +test_mock_acl_helper_SOURCES = mock-acl-helper.c
>  
>  -include $(top_srcdir)/git.mk
> diff --git a/tests/usb-acl-helper.c b/tests/usb-acl-helper.c
> index 41dda5d..6cbc548 100644
> --- a/tests/usb-acl-helper.c
> +++ b/tests/usb-acl-helper.c
> @@ -42,7 +42,7 @@ gboolean cancel_test(gpointer user_data)
>  
>  static void data_setup(Fixture *fixture, gconstpointer user_data)
>  {
> -    g_setenv("SPICE_USB_ACL_BINARY", TESTDIR"/mock-acl-helper", TRUE);
> +    g_setenv("SPICE_USB_ACL_BINARY", TESTDIR"/test-mock-acl-helper", TRUE);
>      fixture->cancellable = g_cancellable_new();
>      fixture->acl_helper = spice_usb_acl_helper_new();
>      fixture->loop = g_main_loop_new(NULL, FALSE);
> -- 
> 2.9.3
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20161003/6b115a4d/attachment.sig>