[Spice-devel] [PATCH qxl-wddm-dod 2/8] Mark all functions that should go to non paged sections

[Christophe Fergeau]

On Wed, Sep 28, 2016 at 10:29:48AM -0400, Frediano Ziglio wrote:
> > This is extremely dangerous!, this can be working without any errors most of
> > the time but in a rare cases this could
> > cause a crash - in case a non pageable function made pageable by this patch -
> > which can be hard to troubleshoot!
> 
> Actually this is not far from what the current code is doing right now and the 
> static analyzer will give a warning for new functions. 
> I checked and all non pageable function before this patch are still non pageable. 

Also, functions which are not annotated with QXL_NON_PAGED are expected
to use the PAGED_CODE() macro, which would give us an assert if this
situation happens (at least if I have followed all of this correctly ;)

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20161003/c02b945b/attachment.sig>