[Spice-devel] [PATCH spice-gtk v3] main: Send monitor config only when it changes

[Pavel Grunt]

On Mon, 2016-10-10 at 17:03 +0200, Christophe Fergeau wrote:
> Hey,
> 
> On Mon, Oct 10, 2016 at 04:09:11PM +0200, Pavel Grunt wrote:
> > The configuration messages are sent only when agent is running.
> > 
> > It is happening all the time that the configuration message was
> > technically not successful (linux guest supports only width of
> > multiple of 8) and in fact it is the reason of this flickering
> > bug. 
> 
> "linux guests supports only width of multiple of 8", I assume you
> mean
> when trying to set the resolution through direct use of KMS? Do you
> know
> why this seems to be working fine when the Xorg QXL driver is in
> use?

I believe the gnome-settings-deamon and mutter are involved in this.
gsd has problems getting edid for qxl under wayland, but I don't know
why
> 
> > > , the server should however not notify of changes if none
> > > happened.
> > 
> > (the change has happened - the primary surface was destroyed)
> > 
> > iow some component should just ignore the size request - it can be
> > client, server or driver (eg. Windows driver ignores that, QXL
> > +Xorg
> > driver ignores that).
> > 
> > Imho server does a correct job - it gets info from the driver that
> > the
> > primary surface was destroyed and it forwards the message to the
> > client.
> 
> What is destroying the primary surface guest-side though? I guess
> this
> happens in the kernel KMS driver as part of the attempted resolution
> change?
yes
> 
> > The other option is to stop using QXL for kms and the patch can be
> > dropped.
> 
> I guess you mean stop using a QXL device when wayland is in use? I
> don't
> think we can realistically do that.
No I meant to stop using qxl for fedora24+ and start using virtio-gpu
instead

Pavel

> 
> Christophe