[Spice-devel] [PATCH spice-gtk v3] main: Send monitor config only when it changes

[Christophe Fergeau]

Hey,

On Mon, Oct 10, 2016 at 05:12:53PM +0200, Pavel Grunt wrote:
> On Mon, 2016-10-10 at 17:03 +0200, Christophe Fergeau wrote:
> > Hey,
> > 
> > On Mon, Oct 10, 2016 at 04:09:11PM +0200, Pavel Grunt wrote:
> > > The configuration messages are sent only when agent is running.
> > > 
> > > It is happening all the time that the configuration message was
> > > technically not successful (linux guest supports only width of
> > > multiple of 8) and in fact it is the reason of this flickering
> > > bug. 
> > 
> > "linux guests supports only width of multiple of 8", I assume you
> > mean
> > when trying to set the resolution through direct use of KMS? Do you
> > know
> > why this seems to be working fine when the Xorg QXL driver is in
> > use?
> 
> I believe the gnome-settings-deamon and mutter are involved in this.

In both cases, mutter is involved, though things are going through 2
different code paths, meta-monitor-manager-xrandr.c VS
meta-monitor-manager-kms.c (and in the latter case some DRM ioctl
failures can indeed be seen, I did not check yet what the xrandr code is
doing).

> gsd has problems getting edid for qxl under wayland, but I don't know
> why

Oh, edid has been removed even from the QXL xorg driver a while ago, I
would not be surprised if we did not have any EDID information anywhere
(
see https://cgit.freedesktop.org/xorg/driver/xf86-video-qxl/commit/?id=96e6be278896ea6ecb43984d7e6fe8eea3b75ab1
)

> > 
> > What is destroying the primary surface guest-side though? I guess
> > this
> > happens in the kernel KMS driver as part of the attempted resolution
> > change?
>
> yes

I think if the resolution change is going to fail, then the primary
surface should not be destroyed. Dunno how unrelated the 2 events are...
This would fix the blinking, but I suspect we'd keep attempting to
change the resolution and fail.


> > 
> > > The other option is to stop using QXL for kms and the patch can be
> > > dropped.
> > 
> > I guess you mean stop using a QXL device when wayland is in use? I
> > don't
> > think we can realistically do that.
> >
> No I meant to stop using qxl for fedora24+ and start using virtio-gpu
> instead

We could recommend not using qxl for f24+, but it's going to be hard to
prevent it totally, and you cannot change it for existing VMs which are
upgraded from f23 to f24 for example. I'd rather than we fix this :)

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20161010/5bc59046/attachment-0001.sig>