[Spice-devel] [PATCH spice-server v8 00/12] Refactory patches updates

Jonathon Jongsma jjongsma at redhat.com
Tue Oct 25 14:55:41 UTC 2016


On Tue, 2016-10-25 at 04:40 -0400, Frediano Ziglio wrote:
> > 
> > 
> > Aside from the comment about potentially splitting patch 11/12, all
> > of
> > the fixups look good to me.
> > 
> 
> Yes, possibly make more sense with the comment in 12/12 although
> they also remove the warning replacing with the old check during
> construction.
> However as they'll be squashed in the same patch does it make sense I
> split it to be then merged again seconds later?
> 
> > 
> > However, I seem to be missing patches 5/12, 9/12, and 12/12. Did
> > they
> > get sent?
> > 
> 
> Weird, maybe some mailman problems:
> https://lists.freedesktop.org/archives/spice-devel/2016-October/03293
> 6.html
> https://lists.freedesktop.org/archives/spice-devel/2016-October/03293
> 2.html
> https://lists.freedesktop.org/archives/spice-devel/2016-October/03293
> 5.html
> 
> Looks like patchwork didn't get the emails.
> 
> You can find them at https://cgit.freedesktop.org/~fziglio/spice-serv
> er/log/?h=jj too.
> 

Yeah, not sure what happened. Those three patches look fine as well.

Jonathon


> > 
> > Jonathon
> > 
> 
> Frediano
> 
> > 
> > 
> > On Mon, 2016-10-24 at 09:40 +0100, Frediano Ziglio wrote:
> > > 
> > > Some different fixup with updates and small changes.
> > > 
> > > Frediano Ziglio (11):
> > >   fixup! Convert RedChannel hierarchy to GObject
> > >   fixup! Convert RedChannel hierarchy to GObject
> > >   fixup! Convert RedChannel hierarchy to GObject
> > >   fixup! Convert RedChannel hierarchy to GObject
> > >   fixup! Convert RedChannel hierarchy to GObject
> > >   fixup! Convert RedChannel hierarchy to GObject
> > >   fixup! Convert RedChannel hierarchy to GObject
> > >   fixup! Convert RedChannel hierarchy to GObject
> > >   fixup! Convert RedChannel hierarchy to GObject
> > >   fixup! Convert RedChannel hierarchy to GObject
> > >   fixup! Convert RedChannel hierarchy to GObject
> > > 
> > > Jonathon Jongsma (1):
> > >   Convert RedChannel hierarchy to GObject
> > > 
> > >  server/Makefile.am                  |   2 +
> > >  server/common-graphics-channel.c    | 111 +++++--
> > >  server/common-graphics-channel.h    |  42 ++-
> > >  server/cursor-channel.c             | 125 ++++----
> > >  server/cursor-channel.h             |  19 +-
> > >  server/dcc-send.c                   |  11 +-
> > >  server/dcc.c                        |   1 +
> > >  server/dcc.h                        |   1 -
> > >  server/display-channel-private.h    |  76 +++++
> > >  server/display-channel.c            | 237 +++++++++++---
> > >  server/display-channel.h            | 100 +++---
> > >  server/dummy-channel-client.c       |  17 +-
> > >  server/dummy-channel.c              |  49 +++
> > >  server/dummy-channel.h              |  60 ++++
> > >  server/inputs-channel.c             | 140 ++++++---
> > >  server/inputs-channel.h             |  19 +-
> > >  server/main-channel-client.c        |  38 +--
> > >  server/main-channel.c               | 153 ++++++---
> > >  server/main-channel.h               |  32 +-
> > >  server/red-channel-client-private.h |  19 ++
> > >  server/red-channel-client.c         | 179 +++++++----
> > >  server/red-channel-client.h         |   4 +-
> > >  server/red-channel.c                | 608
> > > +++++++++++++++++++++++---
> > > ----------
> > >  server/red-channel.h                | 173 +++++-----
> > >  server/red-parse-qxl.h              |   2 +
> > >  server/red-qxl.c                    |  21 +-
> > >  server/red-replay-qxl.c             |   2 +-
> > >  server/red-worker.c                 |  27 +-
> > >  server/red-worker.h                 |   2 -
> > >  server/reds-private.h               |   3 +-
> > >  server/reds.c                       |  68 ++--
> > >  server/smartcard.c                  | 124 ++++++--
> > >  server/sound.c                      |  42 ++-
> > >  server/spicevmc.c                   | 327 +++++++++++++++----
> > >  server/stream.c                     |   4 +-
> > >  35 files changed, 1933 insertions(+), 905 deletions(-)
> > >  create mode 100644 server/display-channel-private.h
> > >  create mode 100644 server/dummy-channel.c
> > >  create mode 100644 server/dummy-channel.h
> > > 
> > 


More information about the Spice-devel mailing list