[Spice-devel] [PATCH spice-server v8 00/12] Refactory patches updates

Frediano Ziglio fziglio at redhat.com
Tue Oct 25 15:08:06 UTC 2016


> 
> On Tue, 2016-10-25 at 04:40 -0400, Frediano Ziglio wrote:
> > > 
> > > 
> > > Aside from the comment about potentially splitting patch 11/12, all
> > > of
> > > the fixups look good to me.
> > > 
> > 
> > Yes, possibly make more sense with the comment in 12/12 although
> > they also remove the warning replacing with the old check during
> > construction.
> > However as they'll be squashed in the same patch does it make sense I
> > split it to be then merged again seconds later?
> > 
> > > 
> > > However, I seem to be missing patches 5/12, 9/12, and 12/12. Did
> > > they
> > > get sent?
> > > 
> > 
> > Weird, maybe some mailman problems:
> > https://lists.freedesktop.org/archives/spice-devel/2016-October/03293
> > 6.html
> > https://lists.freedesktop.org/archives/spice-devel/2016-October/03293
> > 2.html
> > https://lists.freedesktop.org/archives/spice-devel/2016-October/03293
> > 5.html
> > 
> > Looks like patchwork didn't get the emails.
> > 
> > You can find them at https://cgit.freedesktop.org/~fziglio/spice-serv
> > er/log/?h=jj too.
> > 
> 
> Yeah, not sure what happened. Those three patches look fine as well.
> 
> Jonathon
> 

If you agree you can squash them and push, you have my ack.

Frediano


More information about the Spice-devel mailing list