[Spice-devel] [PATCH spice 2/2] Do not enable statistic by default

[Pavel Grunt]

On Thu, 2016-10-27 at 05:56 -0400, Frediano Ziglio wrote:
> > 
> > On Wed, 2016-10-26 at 10:56 -0400, Frediano Ziglio wrote:
> > > > 
> > > > ---
> > > >  server/Makefile.am | 1 -
> > > >  1 file changed, 1 deletion(-)
> > > > 
> > > > diff --git a/server/Makefile.am b/server/Makefile.am
> > > > index 2a6010b..0514a2c 100644
> > > > --- a/server/Makefile.am
> > > > +++ b/server/Makefile.am
> > > > @@ -3,7 +3,6 @@ SUBDIRS = . tests
> > > >  
> > > >  AM_CPPFLAGS =					\
> > > >  	-DSPICE_SERVER_INTERNAL			\
> > > > -	-DRED_STATISTICS			\
> > > >  	$(COMMON_CFLAGS)			\
> > > >  	$(GLIB2_CFLAGS)				\
> > > >  	$(GOBJECT2_CFLAGS)			\
> > > 
> > > I think the rationale here is nobody uses these.
> > 
> > yes. I don't think statistics are interesting for everybody. It is
> > more a feature for developers, lets not force them.
> > 
> > > Actually I think these statistics could be extended with stuff
> > > like image compression (size ratio at least, perhaps cpu could
> > > be expensive).
> > 
> > Why not, it can be useful for the performance measure Jonathon
> > talked
> > about.
> > > 
> > 
> > We have many defines to extend debugging:
> >  * DEBUG
> >  * DEBUG_DISPATCHER
> >  * DEBUG_ENCODE
> >  * COMPRESS_DEBUG
> >  * STREAM_STAT
> >  * COMPRESS_STAT
> >  * RED_WORKER_STAT
> >  * RED_STATISTIC
> > and more are in spice-common
> > 
> > imho we should consider merging them, I believe it would make them
> > easier to use
> > 
> > Pavel
> > 
> 
> Do you have long plan about it?

It can be pretty short :) I will send something

> 
> I think statistics and debugging are quite different stuff.
> An user could be interested in statistics but less in debugging.
> Would be worth perhaps to have a RED_DEBUG and RED_STATISTICS
> to enable all additional debugging and/or statistics.

Yes, having just two would be great
> 
> Tried to look at history to see when RED_STATISTICS was
> enabled but I reached the first commit :(
> 
> Frediano