[Spice-devel] [PATCH spice 2/2] Do not enable statistic by default

[Victor Toso]

Hi,

On Thu, Oct 27, 2016 at 08:58:04AM +0200, Pavel Grunt wrote:
> On Wed, 2016-10-26 at 10:56 -0400, Frediano Ziglio wrote:
> > > 
> > > ---
> > >  server/Makefile.am | 1 -
> > >  1 file changed, 1 deletion(-)
> > > 
> > > diff --git a/server/Makefile.am b/server/Makefile.am
> > > index 2a6010b..0514a2c 100644
> > > --- a/server/Makefile.am
> > > +++ b/server/Makefile.am
> > > @@ -3,7 +3,6 @@ SUBDIRS = . tests
> > >  
> > >  AM_CPPFLAGS =					\
> > >  	-DSPICE_SERVER_INTERNAL			\
> > > -	-DRED_STATISTICS			\
> > >  	$(COMMON_CFLAGS)			\
> > >  	$(GLIB2_CFLAGS)				\
> > >  	$(GOBJECT2_CFLAGS)			\
> > 
> > I think the rationale here is nobody uses these.
> 
> yes. I don't think statistics are interesting for everybody. It is
> more a feature for developers, lets not force them.
> 
> > Actually I think these statistics could be extended with stuff
> > like image compression (size ratio at least, perhaps cpu could
> > be expensive).
> Why not, it can be useful for the performance measure Jonathon talked
> about.
> > 
> We have many defines to extend debugging:
>  * DEBUG
>  * DEBUG_DISPATCHER
>  * DEBUG_ENCODE
>  * COMPRESS_DEBUG
>  * STREAM_STAT
>  * COMPRESS_STAT
>  * RED_WORKER_STAT
>  * RED_STATISTIC
> and more are in spice-common
> 
> imho we should consider merging them, I believe it would make them
> easier to use
>
> Pavel

IMHO, this should be reworked to be enabled dynamically (but disabled by
default) with something like the idea at

https://bugs.freedesktop.org/show_bug.cgi?id=91838#c7

e.g: enable "statistics" domain would output the debugs related to it
(code without #ifdef, everything handled in the g_log world)

>
> > Frediano
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20161027/d07cbdcc/attachment.sig>