[Spice-devel] [PATCH v5] Add ioctls structures to qxl_windows.h

[Frediano Ziglio]

As it's used only by the driver I would prefer defined just in the driver. 

Frediano 

----- Original Message -----

> From: "Sameeh Jubran" <sameeh at daynix.com>
> To: "Frediano Ziglio" <fziglio at redhat.com>
> Cc: "Spice List" <spice-devel at lists.freedesktop.org>, "Dmitry Fleytman"
> <dmitry at daynix.com>
> Sent: Thursday, September 1, 2016 12:58:26 PM
> Subject: Re: [PATCH v5] Add ioctls structures to qxl_windows.h

> On Thu, Sep 1, 2016 at 2:50 PM, Frediano Ziglio < fziglio at redhat.com > wrote:

> > >
> 
> > > This patch defines the structures of ioctls that are used between
> 
> > > win-vdagent and the qxl-wddm-dod driver.
> 
> > >
> 

> > ???
> 

> > didn't we decide to remove this?
> 

> Yes, but this is still used in the driver to determine the ioctl.

> > Frediano
> 

> > > Signed-off-by: Sameeh Jubran < sameeh at daynix.com >
> 
> > > ---
> 
> > > spice/qxl_windows.h | 10 +++++++++-
> 
> > > 1 file changed, 9 insertions(+), 1 deletion(-)
> 
> > >
> 
> > > diff --git a/spice/qxl_windows.h b/spice/qxl_windows.h
> 
> > > index bc2ceff..85f9d79 100644
> 
> > > --- a/spice/qxl_windows.h
> 
> > > +++ b/spice/qxl_windows.h
> 
> > > @@ -2,7 +2,7 @@
> 
> > > #define _H_QXL_WINDOWS
> 
> > >
> 
> > > #include <spice/types.h>
> 
> > > -
> 
> > > +#include <spice/qxl_dev.h>
> 
> > > #include <spice/start-packed.h>
> 
> > >
> 
> > > enum {
> 
> > > @@ -16,6 +16,14 @@ typedef struct SPICE_ATTR_PACKED
> > > QXLEscapeSetCustomDisplay
> 
> > > {
> 
> > > uint32_t bpp;
> 
> > > } QXLEscapeSetCustomDisplay;
> 
> > >
> 
> > > +typedef struct SPICE_ATTR_PACKED QXLEscape {
> 
> > > + uint32_t ioctl;
> 
> > > + union {
> 
> > > + QXLEscapeSetCustomDisplay custom_display;
> 
> > > + QXLHead monitor_config;
> 
> > > + };
> 
> > > +} QXLEscape;
> 
> > > +
> 
> > > #include <spice/end-packed.h>
> 
> > >
> 
> > > #endif /* _H_QXL_WINDOWS */
> 

> --
> Respectfully,
> Sameeh Jubran
> Linkedin
> Junior Software Engineer @ Daynix .
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20160901/9f1609e0/attachment.html>