[Spice-devel] [PATCH spice-server] build-sys: Do not abort on warnings

Pavel Grunt pgrunt at redhat.com
Fri Apr 21 11:31:49 UTC 2017


On Fri, 2017-04-21 at 12:00 +0100, Frediano Ziglio wrote:
> This causes some tests to fail when run on Valgrind.
> In the code warnings are not supposed to cause crashes.
And criticals ? And the fact that it ignores previously set G_DEBUG
etc... It should be submitted upstream (autoconf-archive)

Pavel

> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  m4/ax_valgrind_check.m4 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/m4/ax_valgrind_check.m4 b/m4/ax_valgrind_check.m4
> index 1c1c0cd..b623e3e 100644
> --- a/m4/ax_valgrind_check.m4
> +++ b/m4/ax_valgrind_check.m4
> @@ -198,7 +198,7 @@ VALGRIND_TESTS_ENVIRONMENT = \
>  	$(TESTS_ENVIRONMENT) \
>  	env VALGRIND=$(VALGRIND) \
>  	G_SLICE=always-malloc,debug-blocks \
> -	G_DEBUG=fatal-warnings,fatal-criticals,gc-friendly
> +	G_DEBUG=fatal-criticals,gc-friendly
>  
>  VALGRIND_LOG_COMPILER = \
>  	$(valgrind_lt) \


More information about the Spice-devel mailing list