[Spice-devel] [PATCH spice-server v2] build-sys: Do not abort on warnings
Frediano Ziglio
fziglio at redhat.com
Fri Apr 21 11:54:39 UTC 2017
This causes some tests to fail when run on Valgrind.
In the code warnings are not supposed to cause crashes.
This change avoid overriding entirely G_DEBUG definition but
just append gc-friendly which make Valgrind more effective.
Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
---
m4/ax_valgrind_check.m4 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Changes since v1:
- do not set criticals as fatal;
- do not override entirely G_DEBUG
diff --git a/m4/ax_valgrind_check.m4 b/m4/ax_valgrind_check.m4
index 1c1c0cd..ac62fff 100644
--- a/m4/ax_valgrind_check.m4
+++ b/m4/ax_valgrind_check.m4
@@ -198,7 +198,7 @@ VALGRIND_TESTS_ENVIRONMENT = \
$(TESTS_ENVIRONMENT) \
env VALGRIND=$(VALGRIND) \
G_SLICE=always-malloc,debug-blocks \
- G_DEBUG=fatal-warnings,fatal-criticals,gc-friendly
+ G_DEBUG=$${G_DEBUG:+$$G_DEBUG,}gc-friendly
VALGRIND_LOG_COMPILER = \
$(valgrind_lt) \
--
2.9.3
More information about the Spice-devel
mailing list