[Spice-devel] [PATCH spice-server v2] build-sys: Do not abort on warnings

[Christophe Fergeau]

On Fri, Apr 21, 2017 at 12:54:39PM +0100, Frediano Ziglio wrote:
> This causes some tests to fail when run on Valgrind.
> In the code warnings are not supposed to cause crashes.
> This change avoid overriding entirely G_DEBUG definition but
> just append gc-friendly which make Valgrind more effective.
> 

Have you submitted this for integration in autoconf-archives?
https://savannah.gnu.org/projects/autoconf-archive
It would have been nice to be more specific in the log about tests which
are failing. For what it's worth, when using the GTest API, unexpected
warnings/criticals are also going to be fatal.

Christophe

> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  m4/ax_valgrind_check.m4 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Changes since v1:
> - do not set criticals as fatal;
> - do not override entirely G_DEBUG
> 
> diff --git a/m4/ax_valgrind_check.m4 b/m4/ax_valgrind_check.m4
> index 1c1c0cd..ac62fff 100644
> --- a/m4/ax_valgrind_check.m4
> +++ b/m4/ax_valgrind_check.m4
> @@ -198,7 +198,7 @@ VALGRIND_TESTS_ENVIRONMENT = \
>  	$(TESTS_ENVIRONMENT) \
>  	env VALGRIND=$(VALGRIND) \
>  	G_SLICE=always-malloc,debug-blocks \
> -	G_DEBUG=fatal-warnings,fatal-criticals,gc-friendly
> +	G_DEBUG=$${G_DEBUG:+$$G_DEBUG,}gc-friendly
>  
>  VALGRIND_LOG_COMPILER = \
>  	$(valgrind_lt) \
> -- 
> 2.9.3
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170424/fbc2446e/attachment.sig>