[Spice-devel] [spice-server 1/2] worker: Remove unneeded include

[Christophe Fergeau]

On Fri, Dec 08, 2017 at 09:00:34AM -0500, Frediano Ziglio wrote:
> > 
> > Nothing seems to be using openssl in red-worker.c
> > 
> 
> There are direct call to OpenSSL. Search for "SSL_".
> But openssl/ssl.h is included in red-stream.h which is
> included everywhere :-(

I do not have these here:

$ grep SSL_ server/red-worker.c
$


> I would avoid the include in such a global header just for SSL_CTX
> (which is used) but in the other hand I don't like using a "void *"
> or a "struct ssl_ctx_st *" which I'm not sure is always defined that
> way.

There is only one caller of the only user of SSL_CTX in that header, so
we could move this to a dedicated header, but probably overkill just to
avoid some #include

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20171208/e6a836f8/attachment.sig>