[Spice-devel] [PATCH spice-gtk v2 0/5] Fix introspection method bindings

[Christophe Fergeau]

On Thu, Nov 30, 2017 at 09:33:32AM -0500, Marc-André Lureau wrote:
> Hi
> 
> ----- Original Message -----
> > On Tue, Sep 19, 2017 at 10:33:56PM +0800, Matthew Francis wrote:
> > > Various C functions have not been named correctly to be picked up as bound
> > > methods under introspection. This renames them to ensure correct binding.
> > 
> > I'm very late to the party, but had you considered using (rename-to
> > NEWNAME) annotations rather than wholesale renaming like in this series?
> > This would have meant a lot less changes, with no impact on existing
> > code bases.
> 
> I wished that would work, but that doesn't seem supported. Feel free to find a solution before the next release ;)

It indeed behaves oddly. If I add a (rename-to) for a non-existing
symbol, then it complains during gir generation:
channel-main.h:115: Warning: SpiceClientGLib: Can't find symbol 'spice_main_channel_update_display3' referenced by "rename-to" annotation
but if I add the new symbol, then the (rename-to) seems to do something,
but is pointless as the new symbol will show up in the .gir even if we
don't add any (rename-to). I don't understand what it's meant to be used
for ;)

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20171208/5dd02381/attachment.sig>