[Spice-devel] [server PATCH 2/4] sound: fix params order when calling snd_desired_audio_mode

Uri Lublin uril at redhat.com
Sun Dec 10 11:05:17 UTC 2017


Make sure client_can_celt is passed before client_can_opus

Found by coverity.

Signed-off-by: Uri Lublin <uril at redhat.com>
---
 server/sound.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/server/sound.c b/server/sound.c
index b1bfaaaa9..68f3484d2 100644
--- a/server/sound.c
+++ b/server/sound.c
@@ -1452,7 +1452,7 @@ void snd_set_playback_compression(bool on)
             bool client_can_opus = red_channel_client_test_remote_cap(rcc,
                                     SPICE_PLAYBACK_CAP_OPUS);
             int desired_mode = snd_desired_audio_mode(on, now->frequency,
-                                                      client_can_opus, client_can_celt);
+                                                      client_can_celt, client_can_opus);
             if (playback->mode != desired_mode) {
                 playback->mode = desired_mode;
                 snd_set_command(client, SND_PLAYBACK_MODE_MASK);
-- 
2.14.3



More information about the Spice-devel mailing list