[Spice-devel] [server PATCH 2/4] sound: fix params order when calling snd_desired_audio_mode

[Victor Toso]

Hi,

On Sun, Dec 10, 2017 at 01:05:17PM +0200, Uri Lublin wrote:
> Make sure client_can_celt is passed before client_can_opus
> 
> Found by coverity.

Do you mind including that bug was present since introduction of opus in
ce9b714137a767b81f2d3c40b5f3ce0d5cf70fc8
?
> 
> Signed-off-by: Uri Lublin <uril at redhat.com>
> ---
>  server/sound.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/server/sound.c b/server/sound.c
> index b1bfaaaa9..68f3484d2 100644
> --- a/server/sound.c
> +++ b/server/sound.c
> @@ -1452,7 +1452,7 @@ void snd_set_playback_compression(bool on)
>              bool client_can_opus = red_channel_client_test_remote_cap(rcc,
>                                      SPICE_PLAYBACK_CAP_OPUS);
>              int desired_mode = snd_desired_audio_mode(on, now->frequency,
> -                                                      client_can_opus, client_can_celt);
> +                                                      client_can_celt, client_can_opus);

Acked-by: Victor Toso <victortoso at redhat.com>

>              if (playback->mode != desired_mode) {
>                  playback->mode = desired_mode;
>                  snd_set_command(client, SND_PLAYBACK_MODE_MASK);
> -- 
> 2.14.3
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20171211/5295be2b/attachment.sig>