[Spice-devel] [PATCH 1/7] qxl-wddm-dod: Return EDID data to the OS

[Frediano Ziglio]

> 
> 
> > On 12 Feb 2017, at 14:09, Yuri Benditovich <yuri.benditovich at daynix.com>
> > wrote:
> > 
> > Solves failure of HLK "Test for EDID requirements"
> > EDID contains capabilities and manufacturer data of
> > the emulated display device. Main parameters are:
> > Manufacturer code: QXL
> > Product ID: 0001
> > Working frequency: 75 Hz
> > 
> > Signed-off-by: Yuri Benditovich <yuri.benditovich at daynix.com>
> > ---
> > qxldod/QxlDod.cpp | 50 ++++++++++++++++++++++++++++++++++++++++++++++++--
> > 1 file changed, 48 insertions(+), 2 deletions(-)
> > 
> > diff --git a/qxldod/QxlDod.cpp b/qxldod/QxlDod.cpp
> > index cb64209..35cfb68 100755
> > --- a/qxldod/QxlDod.cpp
> > +++ b/qxldod/QxlDod.cpp
> > @@ -371,6 +371,42 @@ NTSTATUS QxlDod::QueryChildStatus(_Inout_
> > DXGK_CHILD_STATUS* pChildStatus,
> >     }
> > }
> > 
> > +static UCHAR edid[256] =
> > +{
> > +    0x00, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0x00, \
> > +    0x47, 0x0C, 0x01, 0x00, 0x41, 0xFA, 0x38, 0x78, \
> > +    0xFF, 0x1B, 0x01, 0x04, 0x6A, 0x22, 0x1B, 0x78, \
> > +    0xEA, 0x32, 0x31, 0xA3, 0x57, 0x4C, 0x9D, 0x25, \
> > +    0x11, 0x50, 0x54, 0x04, 0x43, 0x00, 0x31, 0x4F, \
> > +    0x45, 0x4F, 0x61, 0x4F, 0x81, 0x4F, 0x01, 0x01, \
> > +    0x01, 0x01, 0x01, 0x01, 0x01, 0x01, 0xBA, 0x2C, \
> > +    0x00, 0xA0, 0x50, 0x00, 0x25, 0x40, 0x30, 0x20, \
> > +    0x37, 0x00, 0x80, 0x00, 0x10, 0x00, 0x00, 0x1E, \
> > +    0x00, 0x00, 0x00, 0xFD, 0x00, 0x38, 0x50, 0x1E, \
> > +    0x53, 0x0F, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, \
> > +    0x00, 0x00, 0x00, 0x00, 0x00, 0xFC, 0x00, 0x51, \
> > +    0x58, 0x4C, 0x30, 0x30, 0x30, 0x31, 0x0A, 0x20, \
> > +    0x20, 0x20, 0x20, 0x20, 0x00, 0x00, 0x00, 0xFC, \
> > +    0x00, 0x51, 0x58, 0x4C, 0x30, 0x30, 0x30, 0x31, \
> > +    0x0A, 0x20, 0x20, 0x20, 0x20, 0x20, 0x01, 0x6E, \

Maybe these last lines could be

   0x00, 0x00, 0x00, 0x00, 0x00, 0xFC, 0x00,  'Q',
   'X',  'L',  '0',  '0',  '0',  '1',  '\n',  ' ',
   ' ',  ' ',  ' ',  ' ',  0x00, 0x00, 0x00, 0xFC,
   0x00, 'Q',  'X',  'L',  '0',  '0',  '0',  '1',
   '\n', ' ',  ' ',  ' ',  ' ',  ' ',  0x01, 0x6E,

Why 2 "Monitor name"  (0xFC) descriptions?

> > +    0x02, 0x03, 0x04, 0x00, 0x00, 0x00, 0x00, 0x00, \
> > +    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, \
> > +    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, \
> > +    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, \
> > +    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, \
> > +    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, \
> > +    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, \
> > +    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, \
> > +    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, \
> > +    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, \
> > +    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, \
> > +    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, \
> > +    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, \
> > +    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, \
> > +    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, \
> > +    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xF7, \
> > +};
> > +
> 
> Is there a way to explain what these numbers mean, e.g. a comment with a copy
> of the output of edit-decode?
> 
> Christophe

Frediano