[Spice-devel] [PATCH spice-server v2] reds-stream: Introduce reds_stream_set_no_delay() helper

[Christophe Fergeau]

On Mon, Feb 27, 2017 at 01:42:37PM +0100, Christophe Fergeau wrote:
> On Mon, Feb 27, 2017 at 12:35:15PM +0000, Frediano Ziglio wrote:
> > From: Christophe Fergeau <cfergeau at redhat.com>
> > 
> > The code to enable/disable on a TCP socket is duplicated in multiple
> > places in the code base, this commit replaces this duplicated code with
> > a helper in RedsStream.
> > ---
> >  server/common-graphics-channel.c | 15 +++------------
> >  server/red-channel-client.c      | 17 ++---------------
> >  server/reds-stream.c             | 16 ++++++++++++++++
> >  server/reds-stream.h             |  1 +
> >  server/reds.c                    |  8 +-------
> >  server/sound.c                   |  8 +-------
> >  6 files changed, 24 insertions(+), 41 deletions(-)
> > 
> > Changes since v1:
> > - boolean style updates
> 
> As far as I'm concerned, NACK to these changes.

With that said, I'm happy with preparing a patch cleaning up
reds-stream.[ch] from a bool/gboolean use point of view.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170227/21000fe5/attachment.sig>