[Spice-devel] [PATCH spice-protocol] Add support for VP9 video codec

[Victor Toso]

Hi,

On Tue, Jan 03, 2017 at 01:42:33PM +0000, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  spice/enums.h    | 1 +
>  spice/protocol.h | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/spice/enums.h b/spice/enums.h
> index 743a4a8..86d02d7 100644
> --- a/spice/enums.h
> +++ b/spice/enums.h
> @@ -148,6 +148,7 @@ typedef enum SpiceVideoCodecType {
>      SPICE_VIDEO_CODEC_TYPE_MJPEG = 1,
>      SPICE_VIDEO_CODEC_TYPE_VP8,
>      SPICE_VIDEO_CODEC_TYPE_H264,
> +    SPICE_VIDEO_CODEC_TYPE_VP9,
>

I don't see a reason to not have it.

In spice-gtk we will need to update gst_opts[] array to include the
protocol + vp9dec bits. (channel-display-gst.c)

In server, although not mandatory, I would include the gstreamer:vp9 in
default_renderer string (reds.c).

One more video-codec, yay. As you are playing with remote virgl and
streaming, I wonder if you have any input in the thread [0]

[0] https://lists.freedesktop.org/archives/spice-devel/2016-December/034692.html

Cheers,

Reviewed-by: Victor Toso <victortoso at redhat.com>

>      SPICE_VIDEO_CODEC_TYPE_ENUM_END
>  } SpiceVideoCodecType;
> diff --git a/spice/protocol.h b/spice/protocol.h
> index d742eda..b618935 100644
> --- a/spice/protocol.h
> +++ b/spice/protocol.h
> @@ -141,6 +141,7 @@ enum {
>      SPICE_DISPLAY_CAP_CODEC_MJPEG,
>      SPICE_DISPLAY_CAP_CODEC_VP8,
>      SPICE_DISPLAY_CAP_CODEC_H264,
> +    SPICE_DISPLAY_CAP_CODEC_VP9,
>  };
>  
>  enum {
> -- 
> 2.9.3
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel