[Spice-devel] [NSIS 1/3] Add Windows 10 support

[Christophe Fergeau]

On Mon, Jan 23, 2017 at 12:02:05PM +0200, Yedidyah Bar David wrote:
> From: Christophe Fergeau <cfergeau at redhat.com>
> 
> This requires WinVer from nsis 3.01.
> At the moment, the qxl-wddm-dod driver on the virtio-win ISO is not the
> latest one from
> https://www.spice-space.org/download/windows/qxl-wddm-dod/
> 
> Change-Id: I773e4b76bd896fcea074b8f32a1b0cff854841b5
> Signed-off-by: Christophe Fergeau <cfergeau at redhat.com>
> ---
>  ovirt-guest-tools-iso.spec.in |   2 +-
> diff --git a/ovirt-guest-tools-iso.spec.in b/ovirt-guest-tools-iso.spec.in
> index 0cd6e09..abab01a 100644
> --- a/ovirt-guest-tools-iso.spec.in
> +++ b/ovirt-guest-tools-iso.spec.in
> @@ -16,7 +16,7 @@ Packager:	Lev Veyde <lveyde at redhat.com>
>  
>  BuildRequires:	genisoimage
>  BuildRequires:	rsync
> -BuildRequires:	mingw32-nsis >= 2.46
> +BuildRequires:	mingw32-nsis >= 3.01
>  
>  # Drop these when virtio-win includes the drivers not inside an iso.
>  # See comment in Makefile.

This is what has changed in this patch, which looks good to me. I'd
specify the version of the nsis-simple-service-plugin though, as nsis2
builds are not going to work with nsis3 (location of the plugin must be
changed).

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170123/313789c1/attachment.sig>