[Spice-devel] [NSIS 1/3] Add Windows 10 support

[Yedidyah Bar David]

On Mon, Jan 23, 2017 at 7:14 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> On Mon, Jan 23, 2017 at 12:02:05PM +0200, Yedidyah Bar David wrote:
>> From: Christophe Fergeau <cfergeau at redhat.com>
>>
>> This requires WinVer from nsis 3.01.
>> At the moment, the qxl-wddm-dod driver on the virtio-win ISO is not the
>> latest one from
>> https://www.spice-space.org/download/windows/qxl-wddm-dod/
>>
>> Change-Id: I773e4b76bd896fcea074b8f32a1b0cff854841b5
>> Signed-off-by: Christophe Fergeau <cfergeau at redhat.com>
>> ---
>>  ovirt-guest-tools-iso.spec.in |   2 +-
>> diff --git a/ovirt-guest-tools-iso.spec.in b/ovirt-guest-tools-iso.spec.in
>> index 0cd6e09..abab01a 100644
>> --- a/ovirt-guest-tools-iso.spec.in
>> +++ b/ovirt-guest-tools-iso.spec.in
>> @@ -16,7 +16,7 @@ Packager:   Lev Veyde <lveyde at redhat.com>
>>
>>  BuildRequires:       genisoimage
>>  BuildRequires:       rsync
>> -BuildRequires:       mingw32-nsis >= 2.46
>> +BuildRequires:       mingw32-nsis >= 3.01
>>
>>  # Drop these when virtio-win includes the drivers not inside an iso.
>>  # See comment in Makefile.
>
> This is what has changed in this patch, which looks good to me. I'd
> specify the version of the nsis-simple-service-plugin though, as nsis2
> builds are not going to work with nsis3 (location of the plugin must be
> changed).

Indeed.

I'll now push/post an updated patch series.

The referenced nsis-simple-service-plugin-1.30-2 was built in oVirt's
jenkins [1] from the spec file in [2].

[1] http://jenkins.ovirt.org/job/nsis-simple-service-plugin_master_create-rpms-fc24-x86_64_merged/4/
[2] https://gerrit.ovirt.org/gitweb?p=ovirt-wgt-toolchain.git;a=tree;f=specs/nsis-simple-service-plugin;h=9dbbcb5741f3d2d3865e89a014e59fb244174f48;hb=HEAD

>
> Christophe



-- 
Didi