[Spice-devel] [spice-server v2 06/10] sound: Remove code from spice_server_record_get_samples()

[Frediano Ziglio]

> 
> It's ok to remove it because ?
> 
> Based on a patch from Frediano Ziglio <fziglio at redhat.com>
> 
> Signed-off-by: Christophe Fergeau <cfergeau at redhat.com>

Because I hate polling and was removed time ago :)

Really, now RedChannelClient try to send/receive data when it can
reducing latency.
This code was here as it was possible that some data was still
pending on the receiving queue due to some polling so it
try to read queue directly if buffer was not fill correctly.

> ---
>  server/sound.c | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/server/sound.c b/server/sound.c
> index 28a290c..6025972 100644
> --- a/server/sound.c
> +++ b/server/sound.c
> @@ -1475,15 +1475,6 @@ SPICE_GNUC_VISIBLE uint32_t
> spice_server_record_get_samples(SpiceRecordInstance
>  
>      len = MIN(record_client->write_pos - record_client->read_pos, bufsize);
>  
> -    if (len < bufsize) {
> -        SndChannel *channel =
> SND_CHANNEL(red_channel_client_get_channel(client->channel_client));
> -        snd_receive(client);
> -        if (!channel->connection) {
> -            return 0;
> -        }
> -        len = MIN(record_client->write_pos - record_client->read_pos,
> bufsize);
> -    }
> -
>      read_pos = record_client->read_pos % RECORD_SAMPLES_SIZE;
>      record_client->read_pos += len;
>      now = MIN(len, RECORD_SAMPLES_SIZE - read_pos);

Frediano