[Spice-devel] [spice-server v2 06/10] sound: Remove code from spice_server_record_get_samples()

Christophe Fergeau cfergeau at redhat.com
Wed Jan 25 16:23:56 UTC 2017


On Tue, Jan 24, 2017 at 08:51:00AM -0500, Frediano Ziglio wrote:
> > 
> > It's ok to remove it because ?
> > 
> > Based on a patch from Frediano Ziglio <fziglio at redhat.com>
> > 
> > Signed-off-by: Christophe Fergeau <cfergeau at redhat.com>
> 
> Because I hate polling and was removed time ago :)
> 
> Really, now RedChannelClient try to send/receive data when it can
> reducing latency.
> This code was here as it was possible that some data was still
> pending on the receiving queue due to some polling so it
> try to read queue directly if buffer was not fill correctly.

So before switching to RedChannelClient, this code should be needed, but
after the switch, it can be removed because the polling is no longer
necessary?

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170125/58472df9/attachment-0001.sig>


More information about the Spice-devel mailing list