[Spice-devel] [PATCH v6 1/5] Quiet uninitialized variable warning.

Frediano Ziglio fziglio at redhat.com
Thu Jan 26 08:05:18 UTC 2017


> 
> Signed-off-by: Michal Suchanek <msuchanek at suse.de>
> ---
> v2:
>  - use g_return_if_reached
> ---
>  src/vdagentd/vdagentd.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/vdagentd/vdagentd.c b/src/vdagentd/vdagentd.c
> index a1faf23..e2d6159 100644
> --- a/src/vdagentd/vdagentd.c
> +++ b/src/vdagentd/vdagentd.c
> @@ -305,6 +305,8 @@ static void do_client_file_xfer(struct
> vdagent_virtio_port *vport,
>          id = d->id;
>          break;
>      }
> +    default:
> +        g_return_if_reached();
>      }
>  
>      conn = g_hash_table_lookup(active_xfers, GUINT_TO_POINTER(id));

This patch got different comments. Ack or nack?

Frediano


More information about the Spice-devel mailing list