[Spice-devel] [PATCH v6 1/5] Quiet uninitialized variable warning.

[Christophe Fergeau]

On Thu, Jan 26, 2017 at 03:05:18AM -0500, Frediano Ziglio wrote:
> > 
> > Signed-off-by: Michal Suchanek <msuchanek at suse.de>
> > ---
> > v2:
> >  - use g_return_if_reached
> > ---
> >  src/vdagentd/vdagentd.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/src/vdagentd/vdagentd.c b/src/vdagentd/vdagentd.c
> > index a1faf23..e2d6159 100644
> > --- a/src/vdagentd/vdagentd.c
> > +++ b/src/vdagentd/vdagentd.c
> > @@ -305,6 +305,8 @@ static void do_client_file_xfer(struct
> > vdagent_virtio_port *vport,
> >          id = d->id;
> >          break;
> >      }
> > +    default:
> > +        g_return_if_reached();
> >      }
> >  
> >      conn = g_hash_table_lookup(active_xfers, GUINT_TO_POINTER(id));
> 
> This patch got different comments. Ack or nack?

At the very least, I'd add
https://lists.freedesktop.org/archives/spice-devel/2017-January/034864.html
to the log. Still a bit reluctant to add this as this is not happening
to me on gcc 6, but my gcc is not warning either if do_client_file_xfer()
is not handling all 3 values that it can be called with, so should not
hurt to have this.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170126/6b6d46f7/attachment.sig>