[Spice-devel] [vdagent-win PATCH 4/4] Store agent process handle instead of using PROCESS_INFORMATION

[Christophe Fergeau]

On Fri, Jul 07, 2017 at 06:31:12AM +0100, Frediano Ziglio wrote:
> @@ -695,20 +695,22 @@ bool VDService::launch_agent()
>  {
>      STARTUPINFO startup_info;
>      BOOL ret = FALSE;
> +    PROCESS_INFORMATION agent_proc_info;
>  
>      ZeroMemory(&startup_info, sizeof(startup_info));
>      startup_info.cb = sizeof(startup_info);
>      startup_info.lpDesktop = const_cast<LPTSTR>(TEXT("Winsta0\\winlogon"));
> -    ZeroMemory(&_agent_proc_info, sizeof(_agent_proc_info));
> +    _agent_process = NULL;
> +    ZeroMemory(&agent_proc_info, sizeof(agent_proc_info));

Minor comment, maybe
+    PROCESS_INFORMATION agent_proc_info = { 0, };
or something like that rather than the explicit ZeroMemory call?

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170707/d8c64aae/attachment.sig>