[Spice-devel] [vdagent-win PATCH 1/4] Make some functions static

[Christophe Fergeau]

Minor nit in patch 4/4, for the series
Acked-by: Christophe Fergeau <cfergeau at redhat.com>


On Fri, Jul 07, 2017 at 06:31:09AM +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
>  vdservice/vdservice.cpp | 32 +++++++++++++++++---------------
>  1 file changed, 17 insertions(+), 15 deletions(-)
> 
> diff --git a/vdservice/vdservice.cpp b/vdservice/vdservice.cpp
> index dc49ec5..e9bf1a2 100644
> --- a/vdservice/vdservice.cpp
> +++ b/vdservice/vdservice.cpp
> @@ -444,7 +444,7 @@ bool VDService::execute()
>      return true;
>  }
>  
> -DWORD64 marshall_string(LPCWSTR str, DWORD max_size, LPBYTE* next_buf, DWORD* used_bytes)
> +static DWORD64 marshall_string(LPCWSTR str, DWORD max_size, LPBYTE* next_buf, DWORD* used_bytes)
>  {
>      DWORD offset = *used_bytes;
>  
> @@ -486,14 +486,15 @@ typedef struct CreateProcessRet {
>      PROCESS_INFORMATION process_information;
>  } CreateProcessRet;
>  
> -BOOL create_session_process_as_user(IN DWORD session_id, IN BOOL use_default_token, IN HANDLE token,
> -                                    IN LPCWSTR application_name, IN LPWSTR command_line,
> -                                    IN LPSECURITY_ATTRIBUTES process_attributes,
> -                                    IN LPSECURITY_ATTRIBUTES thread_attributes,
> -                                    IN BOOL inherit_handles, IN DWORD creation_flags,
> -                                    IN LPVOID environment, IN LPCWSTR current_directory,
> -                                    IN LPSTARTUPINFOW startup_info,
> -                                    OUT LPPROCESS_INFORMATION process_information)
> +static BOOL
> +create_session_process_as_user(IN DWORD session_id, IN BOOL use_default_token, IN HANDLE token,
> +                               IN LPCWSTR application_name, IN LPWSTR command_line,
> +                               IN LPSECURITY_ATTRIBUTES process_attributes,
> +                               IN LPSECURITY_ATTRIBUTES thread_attributes,
> +                               IN BOOL inherit_handles, IN DWORD creation_flags,
> +                               IN LPVOID environment, IN LPCWSTR current_directory,
> +                               IN LPSTARTUPINFOW startup_info,
> +                               OUT LPPROCESS_INFORMATION process_information)
>  {
>      WCHAR win_sta_path[MAX_PATH];
>      HINSTANCE win_sta_handle;
> @@ -624,12 +625,13 @@ BOOL create_session_process_as_user(IN DWORD session_id, IN BOOL use_default_tok
>      return ret;
>  }
>  
> -BOOL create_process_as_user(IN DWORD session_id, IN LPCWSTR application_name,
> -                            IN LPWSTR command_line, IN LPSECURITY_ATTRIBUTES process_attributes,
> -                            IN LPSECURITY_ATTRIBUTES thread_attributes, IN BOOL inherit_handles,
> -                            IN DWORD creation_flags, IN LPVOID environment,
> -                            IN LPCWSTR current_directory, IN LPSTARTUPINFOW startup_info,
> -                            OUT LPPROCESS_INFORMATION process_information)
> +static BOOL
> +create_process_as_user(IN DWORD session_id, IN LPCWSTR application_name,
> +                       IN LPWSTR command_line, IN LPSECURITY_ATTRIBUTES process_attributes,
> +                       IN LPSECURITY_ATTRIBUTES thread_attributes, IN BOOL inherit_handles,
> +                       IN DWORD creation_flags, IN LPVOID environment,
> +                       IN LPCWSTR current_directory, IN LPSTARTUPINFOW startup_info,
> +                       OUT LPPROCESS_INFORMATION process_information)
>  {
>      PROCESSENTRY32 proc_entry;
>      DWORD winlogon_pid = 0;
> -- 
> 2.9.4
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170707/0203649d/attachment-0001.sig>