[Spice-devel] [PATCH spice-html5 4/4] Display: Add support for the VP9 codec type

[Pavel Grunt]

Hi, sure. I'll change it to '==='

(I think in this case it does not matter - it's comparing ints not objects,
but as you said, we should be consistent)

On Tue, Jun 20, 2017 at 10:44 PM, Jeremy White <jwhite at codeweavers.com>
wrote:

> Hi,
>
> One tiny niggle:
>
> On 06/08/2017 09:27 AM, Pavel Grunt wrote:
> > @@ -606,7 +607,8 @@ SpiceDisplayConn.prototype.process_channel_message
> = function(msg)
> >          if (this.streams[m.base.id].codec_type ===
> SPICE_VIDEO_CODEC_TYPE_MJPEG)
> >              process_mjpeg_stream_data(this, m, time_until_due);
> >
> > -        if (this.streams[m.base.id].codec_type ===
> SPICE_VIDEO_CODEC_TYPE_VP8)
> > +        if (this.streams[m.base.id].codec_type ===
> SPICE_VIDEO_CODEC_TYPE_VP8 ||
> > +            this.streams[m.base.id].codec_type ==
> SPICE_VIDEO_CODEC_TYPE_VP9)
> >              process_video_stream_data(this.streams[m.base.id], m);
> >
> >          return true;
>
> The original author of this code did a poor job of deciding whether or
> not to use '===' everywhere or whether to use '=='.  There appears to be
> some debate, with the consensus being that '===' is often more
> appropriate.  Sadly, this code base mixes the two, and mostly uses '=='.
>
> I'd ask that this if statement be at least internally consistent.  I
> don't know that it is clear to me whether it should be '==' or '==='.
>
> Cheers,
>
> Jeremy
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170621/cd674ae7/attachment.html>