[Spice-devel] [spice-common] log: Add missing stdio.h include

Pavel Grunt pgrunt at redhat.com
Fri Mar 31 10:08:04 UTC 2017


On Fri, 2017-03-31 at 12:03 +0200, Christophe Fergeau wrote:
> On Fri, Mar 31, 2017 at 11:50:34AM +0200, Pavel Grunt wrote:
> > On Fri, 2017-03-31 at 05:36 -0400, Frediano Ziglio wrote:
> > > > 
> > > > This is needed because spice_printerr uses fprintf/stderr
> > > > ---
> > > >  common/log.h | 2 ++
> > > >  1 file changed, 2 insertions(+)
> > > > 
> > > > diff --git a/common/log.h b/common/log.h
> > > > index 0e03f59..11261ca 100644
> > > > --- a/common/log.h
> > > > +++ b/common/log.h
> > > > @@ -18,6 +18,8 @@
> > > >  #ifndef H_SPICE_LOG
> > > >  #define H_SPICE_LOG
> > > >  
> > > > +#include <stdio.h>
> > > > +
> > 
> > per spice style there should not be this empty line
> 
> Looks like more moving around would be needed if we want to be
> consistent with the style guide:

imho it is enough to follow the style for the new code, we don't need
to fix everything at once

> 
> #include <stdarg.h>
> #include <stdio.h>
> #include <glib.h>
> #include <spice/macros.h>
> 
> #include "macros.h"
> 
> Christophe


More information about the Spice-devel mailing list