[Spice-devel] [spice-common] log: Add missing stdio.h include

Christophe Fergeau cfergeau at redhat.com
Fri Mar 31 10:13:13 UTC 2017


On Fri, Mar 31, 2017 at 12:08:04PM +0200, Pavel Grunt wrote:
> On Fri, 2017-03-31 at 12:03 +0200, Christophe Fergeau wrote:
> > On Fri, Mar 31, 2017 at 11:50:34AM +0200, Pavel Grunt wrote:
> > > On Fri, 2017-03-31 at 05:36 -0400, Frediano Ziglio wrote:
> > > > > 
> > > > > This is needed because spice_printerr uses fprintf/stderr
> > > > > ---
> > > > >  common/log.h | 2 ++
> > > > >  1 file changed, 2 insertions(+)
> > > > > 
> > > > > diff --git a/common/log.h b/common/log.h
> > > > > index 0e03f59..11261ca 100644
> > > > > --- a/common/log.h
> > > > > +++ b/common/log.h
> > > > > @@ -18,6 +18,8 @@
> > > > >  #ifndef H_SPICE_LOG
> > > > >  #define H_SPICE_LOG
> > > > >  
> > > > > +#include <stdio.h>
> > > > > +
> > > 
> > > per spice style there should not be this empty line
> > 
> > Looks like more moving around would be needed if we want to be
> > consistent with the style guide:
> 
> imho it is enough to follow the style for the new code, we don't need
> to fix everything at once

Fixing the old code in that file was not a big change, so I wanted to
push an amended commit with that fixed, but Frediano beat me to the
pushing :-/

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170331/b5e02d01/attachment.sig>


More information about the Spice-devel mailing list