[Spice-devel] [spice-common] log: Add missing stdio.h include

[Christophe de Dinechin]

BTW, putting local headers first makes it possible to detect missing / implicit dependencies in the header, i.e.:

#include “macros.h”

#include <spice/macros.h>
#include <glib.h>
#include <stdarg.h>
#include <stdio.h>

Christophe

> On 31 Mar 2017, at 12:03, Christophe Fergeau <cfergeau at redhat.com <mailto:cfergeau at redhat.com>> wrote:
> 
> On Fri, Mar 31, 2017 at 11:50:34AM +0200, Pavel Grunt wrote:
>> On Fri, 2017-03-31 at 05:36 -0400, Frediano Ziglio wrote:
>>>> 
>>>> This is needed because spice_printerr uses fprintf/stderr
>>>> ---
>>>>  common/log.h | 2 ++
>>>>  1 file changed, 2 insertions(+)
>>>> 
>>>> diff --git a/common/log.h b/common/log.h
>>>> index 0e03f59..11261ca 100644
>>>> --- a/common/log.h
>>>> +++ b/common/log.h
>>>> @@ -18,6 +18,8 @@
>>>>  #ifndef H_SPICE_LOG
>>>>  #define H_SPICE_LOG
>>>>  
>>>> +#include <stdio.h>
>>>> +
>> per spice style there should not be this empty line
> 
> Looks like more moving around would be needed if we want to be
> consistent with the style guide:
> 
> #include <stdarg.h>
> #include <stdio.h>
> #include <glib.h>
> #include <spice/macros.h>
> 
> #include "macros.h"
> 
> Christophe
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org <mailto:Spice-devel at lists.freedesktop.org>
> https://lists.freedesktop.org/mailman/listinfo/spice-devel <https://lists.freedesktop.org/mailman/listinfo/spice-devel>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170331/b7e4c3eb/attachment.html>