[Spice-devel] [PATCH spice-gtk v2 2/4] Avoid warning about snprintf on non-Linux platforms

Christophe Fergeau cfergeau at redhat.com
Tue May 16 13:00:10 UTC 2017


On Thu, May 11, 2017 at 12:47:06PM +0200, Christophe de Dinechin wrote:
> From: Christophe de Dinechin <dinechin at redhat.com>
> 
> Without #include <stdio.h>, calls to snprintf in the file
> cause a warning. The file <unistd.h> is left aside on purpose,
> since src/usbutil.c may be compiled on Windows where this
> file does not exist.

I'd just switch to g_snprintf.

Christophe

> 
> Signed-off-by: Christophe de Dinechin <dinechin at redhat.com>
> ---
>  src/usbutil.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/usbutil.c b/src/usbutil.c
> index b68a2e1..e96ab11 100644
> --- a/src/usbutil.c
> +++ b/src/usbutil.c
> @@ -27,8 +27,8 @@
>  #include <stdlib.h>
>  
>  #ifdef USE_USBREDIR
> -#ifdef __linux__
>  #include <stdio.h>
> +#ifdef __linux__
>  #include <unistd.h>
>  #include <sys/sysmacros.h>
>  #ifndef major /* major and minor macros were moved to sys/sysmacros.h from sys/types.h */
> -- 
> 2.11.0 (Apple Git-81)
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20170516/0e46880b/attachment.sig>


More information about the Spice-devel mailing list