[Spice-devel] [PATCH spice-gtk v2 2/4] Avoid warning about snprintf on non-Linux platforms

[Frediano Ziglio]

> 
> On Thu, May 11, 2017 at 12:47:06PM +0200, Christophe de Dinechin wrote:
> > From: Christophe de Dinechin <dinechin at redhat.com>
> > 
> > Without #include <stdio.h>, calls to snprintf in the file
> > cause a warning. The file <unistd.h> is left aside on purpose,
> > since src/usbutil.c may be compiled on Windows where this
> > file does not exist.
> 
> I'd just switch to g_snprintf.
> 
> Christophe
> 
> > 
> > Signed-off-by: Christophe de Dinechin <dinechin at redhat.com>

I would ack. I don't think that including stdio.h will cause any
problem as it's one of the most portable headers of C.
It's true that snprintf is not 100% portable but this patch was
made to fix a Mac Os X which has a good (C99) snprintf
implementation.

Frediano

> > ---
> >  src/usbutil.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/src/usbutil.c b/src/usbutil.c
> > index b68a2e1..e96ab11 100644
> > --- a/src/usbutil.c
> > +++ b/src/usbutil.c
> > @@ -27,8 +27,8 @@
> >  #include <stdlib.h>
> >  
> >  #ifdef USE_USBREDIR
> > -#ifdef __linux__
> >  #include <stdio.h>
> > +#ifdef __linux__
> >  #include <unistd.h>
> >  #include <sys/sysmacros.h>
> >  #ifndef major /* major and minor macros were moved to sys/sysmacros.h from
> >  sys/types.h */