[Spice-devel] [PATCH spice-server] Support h265 in stream-channel

Christophe Fergeau cfergeau at redhat.com
Mon Aug 13 15:36:06 UTC 2018


Hey,

At this point, I don't think we have anything which is going to give us
an h265 encoded stream, and latest spice-protocol release is fairly
recent but does not have the SPICE_DISPLAY_CAP_CODEC_H265. I'd like to
temporarily revert this commit for spice-server 0.14.1 so that it does
not depend on spice-protocol.git.

Any thoughts?

Christophe

On Mon, Jun 18, 2018 at 12:20:31PM +0300, Snir Sheriber wrote:
> And update required spice-protocol version to 0.12.15
> 
> Signed-off-by: Snir Sheriber <ssheribe at redhat.com>
> ---
>  configure.ac            | 2 +-
>  server/stream-channel.c | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 2443ccf3..6cbd6a99 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -158,7 +158,7 @@ AS_IF([test x"$have_smartcard" = "xyes"], [
>      AS_VAR_APPEND([SPICE_REQUIRES], [" libcacard >= 0.1.2"])
>  ])
>  
> -SPICE_PROTOCOL_MIN_VER=0.12.14
> +SPICE_PROTOCOL_MIN_VER=0.12.15
>  PKG_CHECK_MODULES([SPICE_PROTOCOL], [spice-protocol >= $SPICE_PROTOCOL_MIN_VER])
>  AC_SUBST([SPICE_PROTOCOL_MIN_VER])
>  
> diff --git a/server/stream-channel.c b/server/stream-channel.c
> index 680fa3d1..a7ab0238 100644
> --- a/server/stream-channel.c
> +++ b/server/stream-channel.c
> @@ -356,6 +356,7 @@ stream_channel_get_supported_codecs(StreamChannel *channel, uint8_t *out_codecs)
>          SPICE_DISPLAY_CAP_CODEC_VP8,
>          SPICE_DISPLAY_CAP_CODEC_H264,
>          SPICE_DISPLAY_CAP_CODEC_VP9,
> +        SPICE_DISPLAY_CAP_CODEC_H265,
>      };
>  
>      bool supported[SPICE_N_ELEMENTS(codec2cap)];
> -- 
> 2.17.0
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180813/dc70b488/attachment-0001.sig>


More information about the Spice-devel mailing list