[Spice-devel] [PATCH spice-server] Support h265 in stream-channel

[Frediano Ziglio]

> 
> Hey,
> 
> At this point, I don't think we have anything which is going to give us
> an h265 encoded stream, and latest spice-protocol release is fairly
> recent but does not have the SPICE_DISPLAY_CAP_CODEC_H265. I'd like to
> temporarily revert this commit for spice-server 0.14.1 so that it does
> not depend on spice-protocol.git.
> 
> Any thoughts?
> 
> Christophe
> 

I would prefer to branch and revert just before the 0.14.1 release instead
so next version won't have revert+again.

Frediano


> On Mon, Jun 18, 2018 at 12:20:31PM +0300, Snir Sheriber wrote:
> > And update required spice-protocol version to 0.12.15
> > 
> > Signed-off-by: Snir Sheriber <ssheribe at redhat.com>
> > ---
> >  configure.ac            | 2 +-
> >  server/stream-channel.c | 1 +
> >  2 files changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/configure.ac b/configure.ac
> > index 2443ccf3..6cbd6a99 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -158,7 +158,7 @@ AS_IF([test x"$have_smartcard" = "xyes"], [
> >      AS_VAR_APPEND([SPICE_REQUIRES], [" libcacard >= 0.1.2"])
> >  ])
> >  
> > -SPICE_PROTOCOL_MIN_VER=0.12.14
> > +SPICE_PROTOCOL_MIN_VER=0.12.15
> >  PKG_CHECK_MODULES([SPICE_PROTOCOL], [spice-protocol >=
> >  $SPICE_PROTOCOL_MIN_VER])
> >  AC_SUBST([SPICE_PROTOCOL_MIN_VER])
> >  
> > diff --git a/server/stream-channel.c b/server/stream-channel.c
> > index 680fa3d1..a7ab0238 100644
> > --- a/server/stream-channel.c
> > +++ b/server/stream-channel.c
> > @@ -356,6 +356,7 @@ stream_channel_get_supported_codecs(StreamChannel
> > *channel, uint8_t *out_codecs)
> >          SPICE_DISPLAY_CAP_CODEC_VP8,
> >          SPICE_DISPLAY_CAP_CODEC_H264,
> >          SPICE_DISPLAY_CAP_CODEC_VP9,
> > +        SPICE_DISPLAY_CAP_CODEC_H265,
> >      };
> >  
> >      bool supported[SPICE_N_ELEMENTS(codec2cap)];