[Spice-devel] [RFC spice-vdagent 00/18] GLib integration

[Jakub Janků]

Hi all,

as the subject suggests, this series further deepens the integration of GLib into spice-vdagent(d).

Change summary:

* udscs.c and virtio-port.c are built upon common base, VDAgentConnection, that handles the lower-level I/O operations
* systemd-login.c and console-kit.c use GDBus instead of libdbus
* vdagentd.c uses GMainLoop and GLib's commandline option parser

Some patches are rather unrelated and try to clean up the code a bit.


Where I'd need your help:

vdagent_connection_destroy() is in most cases asynchronous (due to the way GCancellable works) and it can therefore take multiple iterations of GMainLoop until the memory associated with VDAgentConnection is freed and the underlying file descriptor gets closed.

This is fine as long as the GMainLoop runs. However, the current code assumes, that the call to udscs_destroy_connection() and vdagent_virtio_port_destroy() are synchronous and invokes these functions even after the GMainLoop quits.

As a result, the memory allocated by VDAgentConnection might not be explicitely freed and the FD might not be closed, when the spice-vdagent(d) exits.

Is this an acceptable behavior?

Possible solutions:
1) use GMainLoop inside vdagent_connection_destroy() in a similar way as in vdagent_connection_flush() or in the clipboard.c code
2) add a callback for VDAgentConnection's destruction and make the clean-up code at the end of main() run while the GMainLoop is still alive, the callback would then quit it (this would also require adding destruction callbacks for udscs_connection, udscs_server and virtio_port)

Is there any better solution?

Cheers,
    Jakub

Jakub Janků (18):
  vdagentd: parse argv using GLib
  vport: add by_user param to vdagent_virtio_port_disconnect_callback
  vdagentd: use GMainLoop
  build: add GIO dependency
  add VDAgentConnection
  udscs: add udscs_get_peer_pid()
  udscs: use VDAgentConnection
  udscs-server: split initialization
  udscs: simplify logging
  vport: use VDAgentConnection
  session-info: add ActiveSessionChangeCb
  console-kit: use GDBus
  systemd-login: use GDBus
  session-info: remove session_info_get_fd()
  build: drop DBus dependency
  move to GLib memory functions
  vdagentd: move code to do_guest_xorg_resolution()
  vdagentd: move code to do_agent_file_xfer_status()

 Makefile.am                       |   6 +-
 configure.ac                      |   2 +-
 src/udscs.c                       | 560 +++++++--------------------
 src/udscs.h                       |  58 +--
 src/vdagent-connection.c          | 301 +++++++++++++++
 src/vdagent-connection.h          | 103 +++++
 src/vdagent/vdagent.c             |   3 +-
 src/vdagent/x11-randr.c           |  43 +--
 src/vdagentd/console-kit.c        | 613 ++++++++++--------------------
 src/vdagentd/dummy-session-info.c |   7 +-
 src/vdagentd/session-info.h       |   6 +-
 src/vdagentd/systemd-login.c      | 274 +++++--------
 src/vdagentd/uinput.c             |   9 +-
 src/vdagentd/vdagentd.c           | 472 +++++++++++------------
 src/vdagentd/virtio-port.c        | 404 ++++++--------------
 src/vdagentd/virtio-port.h        |  27 +-
 16 files changed, 1217 insertions(+), 1671 deletions(-)
 create mode 100644 src/vdagent-connection.c
 create mode 100644 src/vdagent-connection.h

-- 
2.17.1