[Spice-devel] [PATCH spice-gtk] fixup! Add support for building with meson/ninja

[Victor Toso]

On Tue, Aug 28, 2018 at 03:54:22PM -0300, Eduardo Lima (Etrunko) wrote:
> I have just sent a similar patch to spice-server, now calculating the
> soversion the same way it is done by libtool, instead of using the
> resulting number directly.
> 
> Signed-off-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>
> ---
>  src/meson.build | 25 +++++++++++++++++++++++--
>  1 file changed, 23 insertions(+), 2 deletions(-)
> 
> diff --git a/src/meson.build b/src/meson.build
> index b9ee039..df7782f 100644
> --- a/src/meson.build
> +++ b/src/meson.build
> @@ -180,8 +180,19 @@ if not spice_gtk_has_version_script
>    spice_gtk_version_script = ['-export-symbols', spice_client_glib_syms_path]
>  endif
>  
> +# soversion
> +# XXX: KEEP IN SYNC WITH src/Makefile.am FILE

I don't really think XXX/FIXME/TODO is necessary as who does the
release should update this, etc.

Still,
Acked-by: Victor Toso <victortoso at redhat.com>

> +# http://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html
> +spice_client_glib_current = 14
> +spice_client_glib_revision = 0
> +spice_client_glib_age = 6
> +spice_client_glib_so_version = ('@0 at .@1 at .@2@'.format(spice_client_glib_current - spice_client_glib_age,
> +                                                     spice_client_glib_age,
> +                                                     spice_client_glib_revision))
> +message('libspice-client-glib.so version: ' + spice_client_glib_so_version)
> +
>  spice_client_glib_lib = library('spice-client-glib-2.0', spice_client_glib_sources,
> -                                version : '8.6.0',
> +                                version : spice_client_glib_so_version,
>                                  install : true,
>                                  include_directories : spice_gtk_include,
>                                  link_args : spice_gtk_link_args + [spice_gtk_version_script],
> @@ -323,8 +334,18 @@ if spice_gtk_has_gtk
>      spice_gtk_version_script = ['-export-symbols', spice_client_gtk_syms_path]
>    endif
>  
> +  # soversion
> +  # XXX: KEEP IN SYNC WITH src/Makefile.am FILE
> +  # http://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html
> +  spice_client_gtk_current = 5
> +  spice_client_gtk_revision = 0
> +  spice_client_gtk_age = 0
> +  spice_client_gtk_so_version = ('@0 at .@1 at .@2@'.format(spice_client_gtk_current - spice_client_gtk_age,
> +                                                       spice_client_gtk_age,
> +                                                       spice_client_gtk_revision))
> +  message('libspice-client-gtk.so version: ' + spice_client_gtk_so_version)
>    spice_client_gtk_lib = library('spice-client-gtk-3.0', spice_client_gtk_sources,
> -                                 version : '5.0.0',
> +                                 version : spice_client_gtk_so_version,
>                                   install : true,
>                                   link_args : spice_gtk_link_args + [spice_gtk_version_script],
>                                   link_depends : spice_client_gtk_syms,
> -- 
> 2.17.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180829/fe247698/attachment.sig>