[Spice-devel] [vdagent-linux v2] systemd: Remove unneded virtio-port dependencies

[Frediano Ziglio]

> 
> The udev rule already adds SYSTEMD_WANTS=spice-vdagentd.socket
> to the relevant virtio devices, which automatically adds Wants=${device}
> to spice-vdagentd.socket (see 'systemctl show spice-vdagentd.socket').
> Adding a Requisite/After for these ports is at best redundant, and most
> likely wrong as this is causing boot time warnings:
> 

Lot of doubts, were you able to reproduce the issue?
Also from https://bugzilla.redhat.com/show_bug.cgi?id=1545212#c8 seems
not clear.
I reproduced setting the serial port redirection to a file and adding or
modifying the kernel command line with "console=ttyS0 init=/bin/bash"
(then executing init with exec /sbin/init).

Looking at systemd documentation is not clear why the Requisite causes
an INFO message. Maybe something is attempting to launch the service?
What happen if Requisite is removed and service is enabled? Are we going
to have an error at every restart?

> [ INFO ] dev-virtio\x2dports-com.redhat.spice.0.device is not active.
> [DEPEND] Dependency failed for Activation socket for spice guest agent
> daemon.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1545212
> 
> Signed-off-by: Christophe Fergeau <cfergeau at redhat.com>
> ---
> Changes since v1: Rebased on top of master
> 
> 
>  data/spice-vdagentd.socket | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/data/spice-vdagentd.socket b/data/spice-vdagentd.socket
> index 613c7ed..f14e662 100644
> --- a/data/spice-vdagentd.socket
> +++ b/data/spice-vdagentd.socket
> @@ -1,8 +1,5 @@
>  [Unit]
>  Description=Activation socket for spice guest agent daemon
> -# only start the socket if the virtio port device exists
> -Requisite=dev-virtio\x2dports-com.redhat.spice.0.device
> -After=dev-virtio\x2dports-com.redhat.spice.0.device
>  
>  [Socket]
>  ListenStream=/var/run/spice-vdagentd/spice-vdagent-sock

Frediano