[Spice-devel] [PATCH v4 08/12] Add guidelines about warnings

[Christophe de Dinechin]

From: Christophe de Dinechin <dinechin at redhat.com>

The objective of these guidelines is that:
- We avoid introducing new warnings
- We know how to fix old ones

Changes since v3:
- Put 'controversial' whitespace proposal in separate patch

Signed-off-by: Christophe de Dinechin <dinechin at redhat.com>
---
 docs/spice_style.txt | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/docs/spice_style.txt b/docs/spice_style.txt
index 977ce154..90ad577d 100644
--- a/docs/spice_style.txt
+++ b/docs/spice_style.txt
@@ -523,3 +523,10 @@ using spice::streaming_agent::some_class;
 +
 [source,cpp]
 namespace ssa = spice::streaming_agent;
+
+Compilation
+-----------
+
+The source code should compile without warnings on all variants of GCC and clang available.
+A patch may be rejected if it introduces new warnings.
+Warnings that appear over time due to improvements in compilers should be fixed in dedicated patches. A patch should not mix warning fixes and other changes.
-- 
2.13.5 (Apple Git-94)