[Spice-devel] [PATCH v4 07/12] Remove confusing example

Christophe de Dinechin christophe at dinechin.org
Thu Feb 15 16:06:20 UTC 2018


From: Christophe de Dinechin <dinechin at redhat.com>

The sentence explaining that example makes no real sense,
the mentioned style is not used by the current code,
and the coding style suggestion is horrendous.

Not to mention that it flies in the face of all automatic indentation
tools I know of.

Change since v3:
- Make wording of commit log "less kind", used Frediano's suggestion

Signed-off-by: Christophe de Dinechin <dinechin at redhat.com>
---
 docs/spice_style.txt | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/docs/spice_style.txt b/docs/spice_style.txt
index 9e6536e4..977ce154 100644
--- a/docs/spice_style.txt
+++ b/docs/spice_style.txt
@@ -319,15 +319,7 @@ if (condition) {
 +
 In case of long condition statement, prefer having additional temporary variable over multiple line condition statement.
 +
-In case of new line in condition statement.
-+
-[source,c]
-----
-if (long_name && very_long_name && very_long ||
-                                               var_name) {
-----
-+
-or indent under the round bracket using spaces
+Indent long conditionals under the opening parenthesis using spaces
 +
 [source,c]
 ----
-- 
2.13.5 (Apple Git-94)



More information about the Spice-devel mailing list