[Spice-devel] [spice-server] style: Slight tweak to the header guard section

Christophe Fergeau cfergeau at redhat.com
Thu Feb 15 16:50:17 UTC 2018


On Thu, Feb 15, 2018 at 04:04:57PM +0100, Christophe de Dinechin wrote:
> 
> 	This style guide only indicates what we aim to achieve. It does not necessarily reflect the current state of the code.
> 
> What about adding:
> 
> 	Consistency matters. It may be preferable to ignore a style recommendation if it helps keeping the code style consistent.

Sounds good to me.

> 
> And in the header part that you were adjusting, I’d be happy if you simply added:
> 
> +C++ headers guards should use // comments.
> +The server consistently use /* */ comments for header guards

I can add the last line if you want, but in my opinion, your
'consistency' addition is enough for that.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180215/12ed256f/attachment.sig>


More information about the Spice-devel mailing list