[Spice-devel] [PATCH v4 06/12] Rephrase section on short functions for readability

Christophe Fergeau cfergeau at redhat.com
Fri Feb 16 09:05:42 UTC 2018


On Thu, Feb 15, 2018 at 05:06:19PM +0100, Christophe de Dinechin wrote:
> From: Christophe de Dinechin <dinechin at redhat.com>
> 
> Signed-off-by: Christophe de Dinechin <dinechin at redhat.com>
> ---
>  docs/spice_style.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/docs/spice_style.txt b/docs/spice_style.txt
> index 996c5cd9..9e6536e4 100644
> --- a/docs/spice_style.txt
> +++ b/docs/spice_style.txt
> @@ -178,7 +178,7 @@ If multiple related constants are to be defined, consider the use of enumeration
>  Short functions
>  ---------------
>  
> -Try to split code to short functions, each having simple functionality, in order to improve code readability and re-usability. Prefix with inline short functions or functions that were splitted for readability reason.
> +Try to split code to short functions, each having simple functionality, in order to improve code readability and re-usability. Prefix with `inline` functions that were splitted for readability reason or that are very short.

I'd just drop the second sentence. The compiler usually knows better.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180216/2ca9bb92/attachment.sig>


More information about the Spice-devel mailing list