[Spice-devel] [PATCH spice-streaming-agent v4 0/2] handle error messages from the server

Lukáš Hrázký lhrazky at redhat.com
Wed Feb 28 10:03:01 UTC 2018


Changes since v3:
- moved the StreamMsgNotifyError struct definition inline
- take into account null termination when determining maximum message
  length
- reversed the message too long condition

Changes since v2:
- removed read_len, decrementing len and incrementing msg pointer as we
  read in read_all()
- used a new struct with 1k fixed message size buffer instead of an
  uint8_t array
- in case of too long a message, read a partial message, log it and
  finish with an exception
- check for minimum error message size

Changes since v1:
- renamed read_message() to read_all()
- read_all now does partial reads and handles EINT
- resolved TODOs in second patch, icreased the message size, use
  sizeof(msg) instead of a constant

Lukáš Hrázký (2):
  Move reading stream messages into a function
  Implement handling of error messages from the server

 src/spice-streaming-agent.cpp | 57 +++++++++++++++++++++++++++++++++----------
 1 file changed, 44 insertions(+), 13 deletions(-)

-- 
2.16.1



More information about the Spice-devel mailing list