[Spice-devel] [PATCH spice-streaming-agent v2] Remove useless warning

Christophe Fergeau cfergeau at redhat.com
Wed Feb 28 16:47:56 UTC 2018


Acked-by: Christophe Fergeau <cfergeau at redhat.com>

On Wed, Feb 28, 2018 at 10:02:27AM +0000, Frediano Ziglio wrote:
> Fields are initialized to zero if not explicitly specified which is
> actually what you usually want so there's no reason to have the
> compiler to generate warning for this.
> 
> Signed-off-by: Frediano Ziglio <fziglio at redhat.com>
> ---
> Changes since v1:
> - removed RFC;
> - changes title;
> - avoid to have -Wmissing-field-initializers followed by -Wno-missing-field-initializers.
> ---
>  m4/spice-compile-warnings.m4 | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/m4/spice-compile-warnings.m4 b/m4/spice-compile-warnings.m4
> index 66d7179..2ed589c 100644
> --- a/m4/spice-compile-warnings.m4
> +++ b/m4/spice-compile-warnings.m4
> @@ -86,6 +86,7 @@ AC_DEFUN([SPICE_COMPILE_WARNINGS],[
>      dontwarn="$dontwarn -Wpointer-sign"
>      dontwarn="$dontwarn -Wpointer-to-int-cast"
>      dontwarn="$dontwarn -Wstrict-prototypes"
> +    dontwarn="$dontwarn -Wmissing-field-initializers"
>  
>      # We want to enable these, but need to sort out the
>      # decl mess with  gtk/generated_*.c
> @@ -108,6 +109,7 @@ AC_DEFUN([SPICE_COMPILE_WARNINGS],[
>      # So we have -W enabled, and then have to explicitly turn off...
>      gl_WARN_ADD([-Wno-sign-compare])
>      gl_WARN_ADD([-Wno-unused-parameter])
> +    gl_WARN_ADD([-Wno-missing-field-initializers])
>      # We can't enable this due to horrible spice_usb_device_get_description
>      # signature
>      gl_WARN_ADD([-Wno-format-nonliteral])
> -- 
> 2.14.3
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180228/b1e2be35/attachment.sig>


More information about the Spice-devel mailing list