[Spice-devel] xf86-video-qxl + libspice-server: no image on FreeBSD

[Oleg Ginzburg]

On Tue, Jan 9, 2018 at 10:09 PM, Frediano Ziglio <fziglio at redhat.com> wrote:

>
>
> > Hello!
>
> > I would really like to see XSpice and xf86-video-qxl on FreeBSD.
>
> > The correction for the FreeBSD build libspice-server.so is quite trivial
> and
> > mechanical (first and dirty version in attach. I'd like to do the FreeBSD
> > port later)
>
> About the patch:
>
>
> --- server/net-utils.c.orig     2017-09-12 15:00:11.000000000 +0300
> +++ server/net-utils.c  2017-12-27 17:40:47.728516000 +0300
> @@ -23,6 +23,9 @@
>  #include <fcntl.h>
>  #include <stdbool.h>
>  #include <string.h>
> +#include <sys/types.h>
> +#include <arpa/inet.h>
> +#include <netinet/in.h>
>  #include <netinet/ip.h>
>  #include <netinet/tcp.h>
>  #include <sys/socket.h>
> @@ -42,7 +45,7 @@
>  {
>      int keepalive = !!enable;
>
> -    if (setsockopt(fd, SOL_SOCKET, SO_KEEPALIVE, &keepalive,
> sizeof(keepalive)) == -1) {
> +    if (setsockopt(fd, IPPROTO_TCP, SO_KEEPALIVE, &keepalive,
> sizeof(keepalive)) == -1) {
>          if (errno != ENOTSUP) {
>              spice_printerr("setsockopt for keepalive failed, %s",
> strerror(errno));
>              return false;
>
>
> no, this should be SOL_SOCKET as documented also in FreeBSD documentation.
>
>
> //skipped//
>


Oops! It's my fault. It seems that this was the cause of the problem. Now
spice/qxl works on FreeBSD as expected:
https://snag.gy/4LSavc.jpg

I've apply your other recommendations and after some testing I will submit
a new ports ( xf86-video-qxl, libspice-server ) into the official FreeBSD
ports tree and publish FreeBSD-specific fixes to this mailing list (in the
hope that you can add it to the upstream)
Thank you very much for your help!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180110/4c101008/attachment.html>