[Spice-devel] xf86-video-qxl + libspice-server: no image on FreeBSD

[Oleg Ginzburg]

On Wed, Jan 17, 2018 at 2:18 PM, Oleg Ginzburg <olevole at olevole.ru> wrote:

>
>
> On Wed, Jan 17, 2018 at 2:02 PM, Christophe Fergeau <cfergeau at redhat.com>
> wrote:
>
>> hey,
>>
>> On Wed, Jan 17, 2018 at 12:15:03PM +0300, Oleg Ginzburg wrote:
>> > Confirm - these changes work successfully, tested on: FreeBSD
>> 11.1-RELEASE
>> > and FreeBSD 12-CURRENT (aka HEAD).
>> >
>> > Will these changes be included in the next release?
>> >
>> > There is another small issue of build libspice-server on FreeBSD
>> > platform: OpenSSL
>> > is included in the FreeBSD base.
>> > However, the pkcconf does not find it without these changes:
>> >
>> > https://reviews.freebsd.org/D13896  ( see
>> head/devel/libspice-server/files/
>> > patch-configure.ac )
>> >
>> > Another way to fix it - install openssl from ports or packages ( while
>> base
>> > OpenSSL placed on /usr/lib and /usr/include, 3-rd packages and openssl
>> from
>> > ports/packages placed in /usr/local prefix and pkgconf finds it).
>> > Nevertheless, at the moment there is no strong reason to add dependency
>> for
>> > OpenSSL from ports/packages.
>> >
>> > Can you review this patch for configure.ac ? I believe this patch can
>> also
>> > be useful for other platforms, including MacOSX.  Perhaps it can also be
>> > included in the upstream. Otherwise, it will remain in FreeBSD ports
>> tree.
>>
>> Ah this is similar to https://cgit.freedesktop.org/s
>> pice/spice-gtk/commit/?id=03d3ea2fa96566dfb413c7f53854390b089f9eed
>> it can definitely be included upstream, though I'd prefer that both
>> spice and spice-gtk does it the same way (both ways are fine with me,
>> the patch you linked to probably saves one call to pkg-config).
>>
>> Christophe
>>
>
> Yea. There are several ways. Unfortunately, I do not know which one
> should be preferred.
> Also, I am maintainer  of spice-gtk port in FreeBSD and it also has
> similar fixes:
>
> https://svnweb.freebsd.org/ports/head/deskutils/spice-
> gtk/files/patch-configure.ac?revision=425018&view=markup
>
>
Sorry, I'm wrong, this patch is not for SSL. At the moment, spice-gtk port
on FreeBSD use  CONFIGURE_ENV to pass SSL_CFLAGS:

https://svnweb.freebsd.org/ports/head/deskutils/spice-gtk/Makefile?revision=456217&view=markup#l37
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/spice-devel/attachments/20180117/b848d583/attachment-0001.html>